-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring most of the project #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les and services.
…bstract * origin/master: [Fix] Added the temporary method call to fix the anr creation from model with linked instances.
…bstract * origin/master: [Fix] Renamed all the usages of recommandation, recommandationSet, and recommandationRisk tables properties names to recommendation
…bstract * origin/master: Cleaned the use section. Fixed issue in string newlines in deliverables generation
…bstract * origin/master: Removed the unused pre-commit hook. Fixed date format required in Front [md-datepicker]
…bstract * origin/master: (43 commits) Fixed the table inheritance. FIxed the op risks creation without tag. CS fixes CS fixes apply previous patch CS fixes. CS fixes. Fixed the maping driver class namespace and cleaned the use sections. Updated doctrine orm module version. Updated the composer config. Fixed import SOA from another referential Fixed the styles. Removed the laminas coding standard. Test of phpcs validation on commit. Updated the files separator. Added the xml with the phpcs rules, test change for failign validation. Fixed the condition in the workflow. Fixed the condition this the workflow. Added the conditions to run only if changed. Test printing of files changes. ... # Conflicts: # src/Service/AnrAmvService.php
…bstract * origin/master: Fixed Amv batch removal to convert the related instance risks to specific. Fixed the amvs removal from the KB, to set instance risks as specific. Fixed the import issue when some data is empty.
… rest controllers after.
…djusted the code.
…onsequences table.
…bstract * origin/master: (36 commits) Fixed the import config retriving. Fixed the long objects' names generation issue and only add 'Imp #' within the same category. Fixed the objects names duplications and added the cache cleanup after import is finished. Update AssetImportService.php Update AssetImportService.php Update ApiAnrObjectsImportController.php Update AnrObjectService.php Update AssetImportService.php Update ApiAnrObjectsImportController.php Update ImportAnalysesCommand.php Update ImportAnalysesCommand.php Added createSnapshot option Removed the extra property definition as it is set in the superclass. Maneged the errors displaying and automatic creation of snapshots before import starts. Update VulnerabilityTable.php Added the cache for threats and vulnerabilities codes during assets' import. Update AssetImportService.php Update ThreatTable.php Updated the status output. Removed the config check in the anr import command, added possibility to delete anr when import error or waiting for imprort. ... # Conflicts: # Module.php # config/module.config.php # src/Import/Service/InstanceImportService.php # src/Import/Service/ObjectImportService.php # src/Model/Table/ThemeTable.php # src/Service/AnrObjectService.php # src/Service/AnrService.php # src/Service/AnrServiceFactory.php # src/Service/AssetImportService.php # src/Table/AmvTable.php # src/Table/ThreatTable.php # src/Table/VulnerabilityTable.php
…ns, removed translations, and a lot more.
…, and vulnerability contraollers, partially anr.
…bstract * origin/master: (21 commits) Update DeliverableGenerationService.php Update AnrThreatService.php Update ApiUserProfileController.php Changed the core lib requirement. Fixed the phinx configuration. Added the necessary return type void. Changed the packages recommended versions. Fixed the CS issue. Removed the error throwing when due date of recommendation is not valid. Fixed the recovery codes obtaining. FIxed the migration filed's length. Fixed the dependency dev version use. Update InstanceImportService.php Fixed merge with master branch Fixed semantic of composer.json fix issue with count add a condition to only count on countable Fixed SOA import for old anr export files Removed useless imagick PHP module Removed the laminas/laminas-console dependency. ... # Conflicts: # composer.json # src/Controller/ApiUserProfileController.php # src/Import/Service/InstanceImportService.php # src/Service/AnrThreatService.php
…bstract * origin/master: Fixed the analysis snashots creation and creation based on the existing analysis in case of custom objects.
…bstract * origin/master: CS fixes. FIxed the issues of count determining in the controller. Fixed the code styles. Code style fixes. Prevented possible errors for the max value calculation. # Conflicts: # src/Stats/Service/StatsAnrService.php
…uage code, and other functionality.
…d recommendations.
… instance risks evals, fixed empty library responce.
ruslanbaidan
changed the title
Refactored the whole project
Refactoring most of the project
Sep 11, 2024
…bstract * origin/master: Update MonarcObject.php Bump tj-actions/changed-files from 12.2 to 41 in /.github/workflows Fixed the removal if specific instance risks. # Conflicts: # src/Model/Entity/MonarcObject.php
…x validation in the service.
…n response with the anr id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code refactoring includes the following parts:
Not refactored parts are the following:
Questions
,QuestionsChoices
,Guide
,Interviews
,ROPA
,Deliverable
.User stories.